Allow chrome to limit the number of FBO status checks

Allow chrome to limit the number of FBO status checks
Committed: https://code.google.com/p/skia/source/detail?r=3144

[bsalomon, 2012-02-06 22:17:56]

Re: http://code.google.com/p/chromium/issues/detail?id=102945 this prevent skia
from repeatedly calling glCheckframebufferStatus when a) initially attaching a
texture to an FBO and b) when attaching a stencil buffer to a texture's FBO.

[TomH, 2012-02-07 15:22:31]

LGTM. I had a couple of concerns, then realized I was misreading the code.

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig.h
File include/gpu/GrGLConfig.h (right):

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig.h#newco...
include/gpu/GrGLConfig.h:98: * environments CheckFrameBufferStatus is very
exepense. If this is set we will
nit: expensive

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig_chrome.h
File include/gpu/GrGLConfig_chrome.h (right):

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig_chrome....
include/gpu/GrGLConfig_chrome.h:34: // CheckFramebufferStatus in chrome
synchronizes the gpu and renderer processes.
Cryptic comment means something to people who understand everything already, but
not to those who don't?

https://codereview.appspot.com/5635052/diff/12/src/gpu/GrGpuGL.cpp
File src/gpu/GrGpuGL.cpp (right):

https://codereview.appspot.com/5635052/diff/12/src/gpu/GrGpuGL.cpp#newcode80
src/gpu/GrGpuGL.cpp:80: // Why are we seeing a stencil format that GLCaps
doesn't know about.
Nit: ?, not .
Also, do we want to put this as a string inside the assert so it's more
informative?

[bsalomon, 2012-02-07 15:45:18]

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig.h
File include/gpu/GrGLConfig.h (right):

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig.h#newco...
include/gpu/GrGLConfig.h:98: * environments CheckFrameBufferStatus is very
exepense. If this is set we will
On 2012/02/07 15:22:32, TomH wrote:
> nit: expensive

Done.

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig_chrome.h
File include/gpu/GrGLConfig_chrome.h (right):

https://codereview.appspot.com/5635052/diff/12/include/gpu/GrGLConfig_chrome....
include/gpu/GrGLConfig_chrome.h:34: // CheckFramebufferStatus in chrome
synchronizes the gpu and renderer processes.
On 2012/02/07 15:22:32, TomH wrote:
> Cryptic comment means something to people who understand everything already,
but
> not to those who don't?

This is in a chrome-specific config file. It's documenting why flags were set a
specific way within chrome. I think it's ok to require the reader to have some
understanding of chrome's architecture.

https://codereview.appspot.com/5635052/diff/12/src/gpu/GrGpuGL.cpp
File src/gpu/GrGpuGL.cpp (right):

https://codereview.appspot.com/5635052/diff/12/src/gpu/GrGpuGL.cpp#newcode80
src/gpu/GrGpuGL.cpp:80: // Why are we seeing a stencil format that GLCaps
doesn't know about.
On 2012/02/07 15:22:32, TomH wrote:
> Nit: ?, not .
> Also, do we want to put this as a string inside the assert so it's more
> informative?

Done.