Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(945)

Issue 563430046: Issue 5707: fix \cueDuring and \quoteDuring display test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5707/ These tests are failing in master @ 2ccac23c0e9f7528e55dfd8d711420b4bc5d7a43. I assume they have been failing for some time. 1: fix \cueDuring and \quoteDuring display test 2: treat warnings as errors in display-lily-tests.ly so that bugs will not be overlooked.

Patch Set 1 #

Patch Set 2 : change the test, not the display function #

Patch Set 3 : revert to original submission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M input/regression/display-lily-tests.ly View 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
Dan Eble
4 years, 3 months ago (2020-01-29 00:06:14 UTC) #1
Dan Eble
> 2: treat warnings as errors in display-lily-tests.ly > so that bugs will not be ...
4 years, 3 months ago (2020-01-29 00:09:44 UTC) #2
dak
On 2020/01/29 00:06:14, Dan Eble wrote: Pretty sure that the trigger was commit ed86e71eb0f17e93036142938d8c490a3e2fcbea Author: ...
4 years, 3 months ago (2020-01-29 00:51:52 UTC) #3
Dan Eble
change the test, not the display function
4 years, 3 months ago (2020-01-29 03:08:48 UTC) #4
Dan Eble
On 2020/01/29 00:09:44, Dan Eble wrote: > > 2: treat warnings as errors in display-lily-tests.ly ...
4 years, 3 months ago (2020-01-29 03:12:28 UTC) #5
dak
On 2020/01/29 03:08:48, Dan Eble wrote: > change the test, not the display function Oh, ...
4 years, 3 months ago (2020-01-29 06:06:15 UTC) #6
Dan Eble
revert to original submission
4 years, 3 months ago (2020-01-29 12:04:56 UTC) #7
Dan Eble
4 years, 3 months ago (2020-01-29 12:06:58 UTC) #8
On 2020/01/29 06:06:15, dak wrote:
> Oh, I am sorry to have been misleading with my comment

forgiven
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b