Issue 5633044: code review 5633044: testing: capture panics, present them, and mark the tes...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5633044: code review 5633044: testing: capture panics, present them, and mark the tes... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by dsymonds

Modified:
13 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

testing: capture panics, present them, and mark the test as a failure.

Patch Set 2 : diff -r abfe7166037c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r abfe7166037c https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 57ea9b58d5fa https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	src/pkg/testing/testing.go	View	1 2 3	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-02-06 02:43:30 UTC) #1

LGTM http://codereview.appspot.com/5633044/diff/4001/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): http://codereview.appspot.com/5633044/diff/4001/src/pkg/testing/testing.go#newcode228 src/pkg/testing/testing.go:228: func (c *common) stack() { // comment and ...

13 years, 2 months ago (2012-02-06 02:48:52 UTC) #2

dsymonds

13 years, 2 months ago (2012-02-06 03:00:30 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=492cbd4a22b1 ***

testing: capture panics, present them, and mark the test as a failure.

R=r
CC=golang-dev
http://codereview.appspot.com/5633044

http://codereview.appspot.com/5633044/diff/4001/src/pkg/testing/testing.go
File src/pkg/testing/testing.go (right):

http://codereview.appspot.com/5633044/diff/4001/src/pkg/testing/testing.go#ne...
src/pkg/testing/testing.go:228: func (c *common) stack() {
On 2012/02/06 02:48:53, r wrote:
> // comment and put the TODO here

Done.

Expand All Messages | Collapse All Messages