Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7215)

Issue 5630043: code review 5630043: spec: restore primality (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by r
Modified:
12 years, 2 months ago
Reviewers:
rog
CC:
golang-dev, gri
Visibility:
Public.

Description

spec: restore primality 9 is prime if it's a hot day.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r fbbc8c80bee2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/go_spec.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2012-02-03 19:02:30 UTC) #1
gri
LGTM http://codereview.appspot.com/5630043/diff/1/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5630043/diff/1/doc/go_spec.html#newcode2146 doc/go_spec.html:2146: primes := []int{2, 3, 5, 7, 9, 11, ...
12 years, 2 months ago (2012-02-03 19:13:10 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=61a004522a55 *** spec: restore primality 9 is prime if it's a hot ...
12 years, 2 months ago (2012-02-03 19:16:08 UTC) #3
rog
12 years, 2 months ago (2012-02-06 10:56:15 UTC) #4
it's a bit odd to say that's an example of a valid slice
literal when it gives a compiler error.

i know that the int values are beside the point, but still.

On 3 February 2012 19:16,  <r@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=61a004522a55 ***
>
>
> spec: restore primality
> 9 is prime if it's a hot day.
>
> R=golang-dev, gri
> CC=golang-dev
> http://codereview.appspot.com/5630043
>
>
> http://codereview.appspot.com/5630043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b