Issue 5622046: Remove two static initializers from debug builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5622046: Remove two static initializers from debug builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by digit

Modified:
12 years, 10 months ago

Reviewers:
DerekS, caryclark1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove two static initializers from debug builds Committed: https://code.google.com/p/skia/source/detail?r=3215

Patch Set 5 : '' #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkTextFormatParams.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

caryclark1

http://codereview.appspot.com/5622046/diff/3001/src/core/SkTextFormatParams.h File src/core/SkTextFormatParams.h (right): http://codereview.appspot.com/5622046/diff/3001/src/core/SkTextFormatParams.h#newcode29 src/core/SkTextFormatParams.h:29: SK_INT_TO_SCALAR_CONST(36) If SK_Scalar1/24 below causes you no trouble, it ...

12 years, 10 months ago (2012-02-07 13:10:06 UTC) #2

digit

http://codereview.appspot.com/5622046/diff/3001/src/core/SkTextFormatParams.h File src/core/SkTextFormatParams.h (right): http://codereview.appspot.com/5622046/diff/3001/src/core/SkTextFormatParams.h#newcode29 src/core/SkTextFormatParams.h:29: SK_INT_TO_SCALAR_CONST(36) On 2012/02/07 13:10:06, caryclark1 wrote: > If SK_Scalar1/24 ...

12 years, 10 months ago (2012-02-07 13:38:50 UTC) #3

LGTM

Expand All Messages | Collapse All Messages