Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3609)

Issue 5616059: Make skdiff always generate white diffs alongside actual pixel diffs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by epoger
Modified:
12 years, 7 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make skdiff always generate white diffs alongside actual pixel diffs (and some associated improvement to the output) Committed: https://code.google.com/p/skia/source/detail?r=3138

Patch Set 1 #

Patch Set 2 : reorder columns: white | diffs | base | comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -29 lines) Patch
M tools/skdiff_main.cpp View 1 15 chunks +57 lines, -29 lines 0 comments Download

Messages

Total messages: 5
epoger
12 years, 7 months ago (2012-02-02 20:00:14 UTC) #1
epoger
(If you'd like to see sample output with these modifications, come on over)
12 years, 7 months ago (2012-02-02 20:01:04 UTC) #2
epoger
On 2012/02/02 20:01:04, epoger wrote: > (If you'd like to see sample output with these ...
12 years, 7 months ago (2012-02-02 20:04:29 UTC) #3
TomH
LGTM. Passing in diffFunction to computeDiff() is now obsolete. I don't have a strong opinion ...
12 years, 7 months ago (2012-02-02 20:38:25 UTC) #4
epoger
12 years, 7 months ago (2012-02-02 20:51:32 UTC) #5
On 2012/02/02 20:38:25, TomH wrote:
> LGTM.
> 
> Passing in diffFunction to computeDiff() is now obsolete.

I left that alone, just in case we wish to add a different diffFunction in the
future.
 
> I don't have a strong opinion about re-ordering the columns, just make sure
you
> look at it yourself first to make sure your intuition is reasonable.

I reordered the columns.  It definitely helps (IMHO)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b