Remove on static initializer in GrGpu.cpp

Remove on static initializer in GrGpu.cpp

This is another go for the patch that was initially
submitted at http://codereview.appspot.com/5504073/ but
crashed the 'gm' unit test.

A problem with the previous implementation is that the
GrStencilSettings ::isDisabled() and ::doesWrite() methods can
modify the object's fFlags member if it is 0, and this will
crash at runtime when doing this for a static constant
object/structure.

I'm not sure why this wasn't triggered previously.

We solve the issue by modifying the implementation of
GR_STATIC_CONST_STENCIL and GR_STATIC_CONST_STENCIL macros to
compute the correct default values for fFlags (which prevents
any member modifications in the above methods).

This requires moving the definition of the disabled/write flags
out of the GrStencilSettings class definition's private section.
Note that the flags are renamed to avoid any confusion and
conflicts, i.e.:

  SkIsDisabled_Flag  -> SkIsDisabled_StencilFlag
  SkNotDisabled_Flag -> SkNotDisabled_StencilFlag
  ...

[digit, 2012-02-07 08:54:20]

ping?

[bsalomon, 2012-02-07 14:03:04]

On 2012/02/07 13:52:34, djsollen wrote:

Yikes. LGTM.

[reed1, 2012-02-07 14:16:38]

http://codereview.appspot.com/5616051/diff/1/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (left):

http://codereview.appspot.com/5616051/diff/1/src/gpu/GrGpu.h#oldcode358
src/gpu/GrGpu.h:358: static const GrStencilSettings& gClipStencilSettings;
nit: skia doesn't say "void" in functions w/ no parameters.

http://codereview.appspot.com/5616051/diff/1/src/gpu/GrStencil.h
File src/gpu/GrStencil.h (right):

http://codereview.appspot.com/5616051/diff/1/src/gpu/GrStencil.h#newcode87
src/gpu/GrStencil.h:87: enum GrStencilFlag{
nit: GrStencilFlags {

[digit, 2012-02-07 14:27:52]

On 2012/02/07 14:16:38, reed1 wrote:
> http://codereview.appspot.com/5616051/diff/1/src/gpu/GrGpu.h
> File src/gpu/GrGpu.h (left):
> 
> http://codereview.appspot.com/5616051/diff/1/src/gpu/GrGpu.h#oldcode358
> src/gpu/GrGpu.h:358: static const GrStencilSettings& gClipStencilSettings;
> nit: skia doesn't say "void" in functions w/ no parameters.
> 
> http://codereview.appspot.com/5616051/diff/1/src/gpu/GrStencil.h
> File src/gpu/GrStencil.h (right):
> 
> http://codereview.appspot.com/5616051/diff/1/src/gpu/GrStencil.h#newcode87
> src/gpu/GrStencil.h:87: enum GrStencilFlag{
> nit: GrStencilFlags {

Thanks Mike, I'll fix the nits.

[reed1, 2012-02-15 21:49:14]

Sorry, I didn't see the lovely nit fixes :)

lgtm