code review 5615058: build: use cmd/dist

src/make.bash

 #!/usr/bin/env bash
 # Copyright 2009 The Go Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style
 # license that can be found in the LICENSE file.
 
 set -e
 if [ ! -f run.bash ]; then
         echo 'make.bash must be run from $GOROOT/src' 1>&2
         exit 1
 fi
 
 # Test for bad ld.

[bradfitz, 2012/02/03 08:42:48]

Why is this in make.bash and in dist?

$ grep gold *.c
build.c:	if(contains(bstr(&b), "gold") && contains(bstr(&b), " 2.20")) {
build.c:		fatal("Your system has gold 2.20 installed.\n"
build.c:			"Run sudo apt-get remove binutils-gold.");

 if ld --version 2>&1 | grep 'gold.* 2\.20' >/dev/null; then
         echo 'ERROR: Your system has gold 2.20 installed.'
         echo 'This version is shipped by Ubuntu even though'
         echo 'it is known not to work on Ubuntu.'
         echo 'Binaries built with this linker are likely to fail in mysterious ways.'
         echo
         echo 'Run sudo apt-get remove binutils-gold.'
         echo
         exit 1
 fi
@@ skipping 17 matching lines @@
 
                         sleep 5
                 fi
         fi
 done
 
 # Finally!  Run the build.
 
 echo '# Building C bootstrap tool.'
 mkdir -p ../bin/tool
-gcc -O2 -o ../bin/tool/dist cmd/dist/*.c
+gcc -O2 -Wall -Werror -o ../bin/tool/dist -Icmd/dist cmd/dist/*.c
+echo
 
 echo '# Building compilers and Go bootstrap tool.'
-../bin/tool/dist bootstrap # builds go_bootstrap
+../bin/tool/dist bootstrap -v # builds go_bootstrap
+echo
 
 echo '# Building packages and commands.'
 ../bin/tool/go_bootstrap clean std
 ../bin/tool/go_bootstrap install -a -v std
 rm -f ../bin/tool/go_bootstrap
+echo
 
-../bin/tool/dist installed

[bradfitz, 2012/02/03 08:42:48]

isn't this done in all.bash too? oh, or that just sources this.

+if [ "$1" != "--no-banner" ]; then
+        ../bin/tool/dist banner
+fi