Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 5615056: code review 5615056: weekly.2012-02-07 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
CC:
golang-dev, dsymonds, r
Visibility:
Public.

Description

weekly.2012-02-07

Patch Set 1 #

Patch Set 2 : diff -r 062ed4b8b8de https://go.googlecode.com/hg #

Total comments: 4

Patch Set 3 : diff -r 1ca43e8ce166 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +190 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
9 years, 8 months ago (2012-02-03 05:10:30 UTC) #1
dsymonds
LGTM
9 years, 8 months ago (2012-02-06 05:41:17 UTC) #2
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-02-08 02:47:13 UTC) #3
dsymonds
LGTM
9 years, 8 months ago (2012-02-08 03:16:38 UTC) #4
r
LGTM http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode24 doc/devel/weekly.html:24: This puts the lesser-used tools (6g, cgo, govet, ...
9 years, 8 months ago (2012-02-08 03:29:16 UTC) #5
adg
9 years, 8 months ago (2012-02-08 03:37:53 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=52ba9506bd99 ***

weekly.2012-02-07

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5615056

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode24
doc/devel/weekly.html:24: This puts the lesser-used tools (6g, cgo, govet, etc)
outside the user PATH.
On 2012/02/08 03:29:16, r wrote:
> s/etc/&./

Done.

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode183
doc/devel/weekly.html:183: restore primality.
On 2012/02/08 03:29:16, r wrote:
> this accumulates to only one change, which is adding a prime number.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b