Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments. Please
Sign in
to add in-line comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(271)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Side by Side Diff: src/liblink/obj5.c
Issue
56120043
:
code review 56120043: liblink, runtime: fix cgo on arm (Closed)
Patch Set: diff -r 0dff07f88a28 https://code.google.com/p/go/
Created 11 years, 1 month ago
Left:
Base
Patch Set 1: None
Patch Set 2: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 3: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 4: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 5: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 6: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 7: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 8: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 9: diff -r 847f3d4e7104 https://code.google.com/p/go/
Patch Set 10: diff -r 0dff07f88a28 https://code.google.com/p/go/
Right:
Patch Set 1: None
Patch Set 2: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 3: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 4: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 5: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 6: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 7: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 8: diff -r f9e8a970798c https://code.google.com/p/go/
Patch Set 9: diff -r 847f3d4e7104 https://code.google.com/p/go/
Patch Set 10: diff -r 0dff07f88a28 https://code.google.com/p/go/
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
src/cmd/ld/data.c
src/cmd/ld/lib.c
src/liblink/asm5.c
src/liblink/obj5.c
src/pkg/runtime/asm_arm.s
View unified diff
|
Download patch
« no previous file with comments
|
« src/liblink/asm5.c
('k') |
src/pkg/runtime/asm_arm.s »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
error: old chunk mismatch
OLD
NEW
« no previous file with comments
|
« src/liblink/asm5.c
('k') |
src/pkg/runtime/asm_arm.s »
('j') |
no next file with comments »
Issue 56120043: code review 56120043: liblink, runtime: fix cgo on arm (Closed)
Created 11 years, 1 month ago by rsc
Modified 11 years, 1 month ago
Reviewers:
Base URL:
Comments: 3
Recent Issues
|
This issue
This is Rietveld
f62528b
