code review 5608059: build: dist-based build for Plan 9

src/cmd/dist/a.h

 // Copyright 2012 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 typedef int bool;
 
 // The Time unit is unspecified; we just need to
 // be able to compare whether t1 is older than t2 with t1 < t2.
 typedef long long Time;
 
+#ifdef PLAN9

[rsc, 2012/02/04 06:52:56]

Sorry, but a.h must not include any other headers.
That's how we make sure the non-os files are not 
accidentally using non-portable functionality.

The only change this file should need is
#ifndef PLAN9 / #endif around the #define USED.

In plan9.c, you should be able to do:

#include <u.h>
#include <libc.h>
#undef nil
#undef nelem
#include "a.h"

[ality, 2012/02/04 07:23:13]

Done.

+#include <u.h>
+#include <libc.h>
+#else
 #define nil ((void*)0)
 #define nelem(x) (sizeof(x)/sizeof((x)[0]))
 #define USED(x) ((void)(x))
+#endif
 
 // A Buf is a byte buffer, like Go's []byte.
 typedef struct Buf Buf;
 struct Buf
 {
         char *p;
         int len;
         int cap;
 };
 
@@ skipping 114 matching lines @@
 void    xrealwd(Buf *b, char *path);
 void    xremove(char *p);
 void    xremoveall(char *p);
 void    xsetenv(char*, char*);
 int     xstrcmp(char*, char*);
 char*   xstrdup(char *p);
 int     xstrlen(char*);
 char*   xstrrchr(char*, int);
 char*   xstrstr(char*, char*);
 char*   xworkdir(void);