Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(975)

Issue 560790043: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by lilypond-pkx
Modified:
12 months ago
Reviewers:
anthoneyhughes88, hassan.elfatihi, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly Using information provided by Hassan Elfatihi this section now includes references to the significantly updated hel-arabic.ly file. Other fixes include making sure we follow CG policy with @seealso ordering as well as line length and some @notation{} syntax additions.

Patch Set 1 #

Total comments: 20

Patch Set 2 : Werner's corrections. #

Patch Set 3 : With Hassan's correction. Thanks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -50 lines) Patch
M Documentation/notation/world.itely View 1 2 10 chunks +83 lines, -50 lines 0 comments Download

Messages

Total messages: 16
lemzwerg
Some typographic issues. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185 Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note ...
1 year ago (2019-07-01 02:54:34 UTC) #1
anthoneyhughes88
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185 Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to ...
1 year ago (2019-07-01 11:12:45 UTC) #2
anthoneyhughes88
1 year ago (2019-07-01 11:19:24 UTC) #3
anthoneyhughes88
1 year ago (2019-07-01 11:20:37 UTC) #4
anthoneyhughes88
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly
1 year ago (2019-07-01 11:22:25 UTC) #5
anthoneyhughes88
1 year ago (2019-07-01 11:22:43 UTC) #6
anthoneyhughes88
On 2019/07/01 11:22:43, anthoneyhughes88 wrote:
1 year ago (2019-07-01 11:23:49 UTC) #7
anthoneyhughes88
Documentation/notation/world.itely https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185 Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to ...
1 year ago (2019-07-01 11:29:56 UTC) #8
anthoneyhughes88
560790043
1 year ago (2019-07-01 11:31:06 UTC) #9
anthoneyhughes88
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode257 Documentation/notation/world.itely:257: are defined in either @code{hel-arabic} or @file{arabic.ly} files and ...
1 year ago (2019-07-01 11:42:04 UTC) #10
anthoneyhughes88
https://codereview.appspot.com/560790043/
1 year ago (2019-07-01 11:44:09 UTC) #11
lilypond-pkx
Thanks Werner https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185 Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names ...
1 year ago (2019-07-02 20:32:03 UTC) #12
lilypond-pkx
Werner's corrections.
1 year ago (2019-07-02 20:32:27 UTC) #13
hassan.elfatihi_free.fr
Hello everyone About hel-arabic.ly It seems to me that the example given is incomplete You ...
1 year ago (2019-07-07 10:01:19 UTC) #14
lilypond-pkx
With Hassan's correction. Thanks
1 year ago (2019-07-07 16:36:19 UTC) #15
lilypond-pkx
12 months ago (2019-07-14 12:25:20 UTC) #16
~~~
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly staging
author	Hassan Elfatihi <hassan.elfatihi@free.fr>	
	Sun, 30 Jun 2019 10:49:45 +0100 (10:49 +0100)
committer	James Lowe <pkx166h@runbox.com>	
	Sun, 14 Jul 2019 13:22:41 +0100 (13:22 +0100)
commit	c24f83991b772a65c15b6290cf70d725def117bd
~~~

Hassan did comment on the example used, but I will deal with that in a separate
patch.

Closing this one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b