Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1955)

Issue 5607058: Disable optimization of certain bit-shift operations on Visual Studio 2010 only (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by epoger
Modified:
12 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Disable optimization of certain bit-shift operations on Visual Studio 2010 only to address http://code.google.com/p/skia/issues/detail?id=472 Committed: https://code.google.com/p/skia/source/detail?r=3137

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/effects/SkGradientShader.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
epoger
I figured target disabling of optimization was the cleanest solution, but I'm open to other ...
12 years, 10 months ago (2012-02-01 21:14:31 UTC) #1
epoger
patchset 2: updated to account for Mike's rearrangement of the mirror macros (all in one ...
12 years, 10 months ago (2012-02-02 20:40:28 UTC) #2
epoger
12 years, 10 months ago (2012-02-02 20:41:03 UTC) #3
LGTM from Mike (verbal)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b