Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 5599053: code review 5599053: gc, cc: avoid using the wrong library when building the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by ality
Modified:
13 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gc, cc: avoid using the wrong library when building the compilers This can happen on Plan 9 if we we're building with the 32-bit and 64-bit host compilers, one after the other.

Patch Set 1 #

Patch Set 2 : diff -r e3cbb4364149 https://code.google.com/p/go #

Patch Set 3 : diff -r e3cbb4364149 https://code.google.com/p/go #

Patch Set 4 : diff -r d1f4e7806ffe https://code.google.com/p/go #

Patch Set 5 : diff -r e9677eca3648 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M .hgignore View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/cc/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
ality
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years, 3 months ago (2012-01-31 12:19:12 UTC) #1
rsc
LGTM
13 years, 3 months ago (2012-01-31 15:47:08 UTC) #2
ality
13 years, 3 months ago (2012-02-01 12:14:46 UTC) #3
*** Submitted as 05ce1def5def ***

gc, cc: avoid using the wrong library when building the compilers

This can happen on Plan 9 if we we're building
with the 32-bit and 64-bit host compilers, one
after the other.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5599053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b