Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19529)

Issue 5599052: Generate vapi from gir instead of gi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Daiki Ueno
Modified:
12 years, 3 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Generate vapi from gir instead of gi. BUG=none TEST=manually on Fedora 16

Patch Set 1 #

Patch Set 2 : rebased against the latest master (with GIR fixes) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8866 lines) Patch
A bindings/vala/IBus-1.0.metadata View 1 chunk +1 line, -0 lines 0 comments Download
A bindings/vala/IBus-1.0-custom.vala View 1 1 chunk +9 lines, -0 lines 0 comments Download
M bindings/vala/Makefile.am View 1 1 chunk +19 lines, -7 lines 2 comments Download
D bindings/vala/ibus-1.0.vapi View 1 chunk +0 lines, -4638 lines 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.defines View 1 chunk +0 lines, -1 line 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.excludes View 1 chunk +0 lines, -4 lines 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.files View 1 chunk +0 lines, -2 lines 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.gi View 1 chunk +0 lines, -4204 lines 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.metadata View 1 chunk +0 lines, -10 lines 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0.namespace View 1 chunk +0 lines, -1 line 0 comments Download
D bindings/vala/ibus-1.0/ibus-1.0-custom.vala View 0 chunks +-1 lines, --1 lines 0 comments Download
M configure.ac View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Daiki Ueno
12 years, 3 months ago (2012-01-31 04:29:03 UTC) #1
Peng
On 2012/01/31 04:29:03, Daiki Ueno wrote: https://github.com/phuang/ibus/tree/devel i am developing ibus 1.5 in my personal ...
12 years, 3 months ago (2012-01-31 04:39:09 UTC) #2
Daiki Ueno
On 2012/01/31 04:39:09, Peng wrote: > On 2012/01/31 04:29:03, Daiki Ueno wrote: > > https://github.com/phuang/ibus/tree/devel ...
12 years, 3 months ago (2012-01-31 05:02:42 UTC) #3
Peng
On 2012/01/31 05:02:42, Daiki Ueno wrote: > On 2012/01/31 04:39:09, Peng wrote: > > On ...
12 years, 3 months ago (2012-01-31 15:25:02 UTC) #4
Peng
On 2012/01/31 15:25:02, Peng wrote: > On 2012/01/31 05:02:42, Daiki Ueno wrote: > > On ...
12 years, 3 months ago (2012-01-31 15:33:40 UTC) #5
Peng
http://codereview.appspot.com/5599052/diff/14/bindings/vala/Makefile.am File bindings/vala/Makefile.am (right): http://codereview.appspot.com/5599052/diff/14/bindings/vala/Makefile.am#newcode29 bindings/vala/Makefile.am:29: # don't rebuild vapi every time gir is updated ...
12 years, 3 months ago (2012-01-31 15:37:43 UTC) #6
Daiki Ueno
On 2012/01/31 15:33:40, Peng wrote: > On 2012/01/31 15:25:02, Peng wrote: > > On 2012/01/31 ...
12 years, 3 months ago (2012-02-01 00:57:43 UTC) #7
Daiki Ueno
12 years, 3 months ago (2012-02-01 00:58:52 UTC) #8
https://codereview.appspot.com/5599052/diff/14/bindings/vala/Makefile.am
File bindings/vala/Makefile.am (right):

https://codereview.appspot.com/5599052/diff/14/bindings/vala/Makefile.am#newc...
bindings/vala/Makefile.am:29: # don't rebuild vapi every time gir is updated
On 2012/01/31 15:37:44, Peng wrote:
> Don't rebuild vapi every time, if gir is updated.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b