Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 55990043: Enable python3. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by fujiwara
Modified:
12 years ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus-tmpl.git@master
Visibility:
Public.

Description

Enable python3. The default is to use 'python' and --with-python option can change it. ./configure --with-python=python3 .

Patch Set 1 #

Patch Set 2 : Upload again. #

Total comments: 7

Patch Set 3 : Updated with message #4. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -56 lines) Patch
M configure.ac View 4 chunks +10 lines, -4 lines 0 comments Download
M engine/Makefile.am View 3 chunks +3 lines, -3 lines 0 comments Download
M engine/enchant-python.xml.in.in View 2 chunks +2 lines, -2 lines 0 comments Download
M engine/engine.py View 1 2 7 chunks +16 lines, -13 lines 0 comments Download
D engine/ibus-engine-enchant.in View 1 chunk +0 lines, -23 lines 0 comments Download
A + engine/ibus-engine-enchant-python.in View 2 chunks +2 lines, -2 lines 0 comments Download
M engine/main.py View 1 2 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7
fujiwara
12 years ago (2014-01-23 10:31:39 UTC) #1
Peng
On 2014/01/23 10:31:39, fujiwara wrote: Can not see diff. Please re-upload it.
12 years ago (2014-01-23 12:20:06 UTC) #2
fujiwara
On 2014/01/23 12:20:06, Peng wrote: > On 2014/01/23 10:31:39, fujiwara wrote: > Can not see ...
12 years ago (2014-01-24 02:07:14 UTC) #3
Peng
https://codereview.appspot.com/55990043/diff/20001/engine/engine.py File engine/engine.py (right): https://codereview.appspot.com/55990043/diff/20001/engine/engine.py#newcode21 engine/engine.py:21: import enchant I think it is better import __future__ ...
12 years ago (2014-01-24 02:43:37 UTC) #4
fujiwara
https://codereview.appspot.com/55990043/diff/20001/engine/engine.py File engine/engine.py (right): https://codereview.appspot.com/55990043/diff/20001/engine/engine.py#newcode21 engine/engine.py:21: import enchant On 2014/01/24 02:43:37, Peng wrote: > I ...
12 years ago (2014-01-27 04:22:47 UTC) #5
Peng
On 2014/01/27 04:22:47, fujiwara wrote: > https://codereview.appspot.com/55990043/diff/20001/engine/engine.py > File engine/engine.py (right): > > https://codereview.appspot.com/55990043/diff/20001/engine/engine.py#newcode21 > ...
12 years ago (2014-01-27 18:49:09 UTC) #6
Peng
12 years ago (2014-01-27 18:49:18 UTC) #7
https://codereview.appspot.com/55990043/diff/20001/engine/engine.py
File engine/engine.py (right):

https://codereview.appspot.com/55990043/diff/20001/engine/engine.py#newcode21
engine/engine.py:21: import enchant
On 2014/01/27 04:22:47, fujiwara wrote:
> On 2014/01/24 02:43:37, Peng wrote:
> > I think it is better import __future__ in every files which use the python3
> > features.
> 
> Added __future__.
> But I still don't think it's not needed because we won't maintain python2 and
> continue to use the python3 format, make sure the double quoted sentence.
> 
> Other migration does not use __future__.
> https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting

At least if will forbid that IME developers use python2 style print in their
IMEs based on ibus-tmpl. It will save our efforts for fixing thrid-party IMEs
later.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b