Issue 559820044: rational: optimize comparison

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 559820044: rational: optimize comparison (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by hanwenn

Modified:
4 years ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

rational: optimize comparison calculating sign(left-right) is correct, but requires an unnecessary GCD calculation to normalize the result. Rational::compare takes about 1% of cumulative time in the carver MDSM profile

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	flower/GNUmakefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/rational.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	flower/test-rational.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download