Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(862)

Issue 559700043: Issue 5036: 128 beaming output not producing output as expected (?)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by Be-3
Modified:
3 months, 2 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5036: 128 beaming output not producing output as expected (?) In case of more than 4 normal-sized beams, a grid shift correction will be applied to the outside-staff quants so that the inner beams within the staff can be neatly aligned to the staff lines. If all the beams fall outside the staff (cf. stem shortening), this grid shift will ensure a consistent vertical alignment of beams. See regtest beam-shortened-lengths.ly regression beam-shortened-lengths.ly: new durations 256, 512, and 1024 added. new regression beaming-more-than-4-beams-normal-size.ly

Patch Set 1 #

Total comments: 4

Patch Set 2 : overall max_beam_count (not just at the edges) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M input/regression/beam-shortened-lengths.ly View 2 chunks +2 lines, -2 lines 0 comments Download
A input/regression/beaming-more-than-4-beams-normal-size.ly View 1 1 chunk +39 lines, -0 lines 0 comments Download
M lily/beam-quanting.cc View 1 3 chunks +23 lines, -5 lines 0 comments Download
M lily/include/beam-scoring-problem.hh View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Be-3
Please review. TIA, Torsten
3 months, 2 weeks ago (2020-03-24 18:21:06 UTC) #1
lemzwerg
LGTM https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly File input/regression/beaming-more-than-4-beams-normal-size.ly (right): https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly#newcode7 input/regression/beaming-more-than-4-beams-normal-size.ly:7: smoothly as possible (standard-sized beams). The outide-staff beams ...
3 months, 2 weeks ago (2020-03-24 18:54:34 UTC) #2
Be-3
Proposed corrections/changes applied to input/regression/beaming-more-than-4-beams-normal-size.ly in my local branch. https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly File input/regression/beaming-more-than-4-beams-normal-size.ly (right): https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly#newcode7 input/regression/beaming-more-than-4-beams-normal-size.ly:7: ...
3 months, 2 weeks ago (2020-03-24 19:32:05 UTC) #3
Be-3
3 months, 2 weeks ago (2020-03-25 11:24:06 UTC) #4
overall max_beam_count (not just at the edges)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b