Issue 5595048: code review 5595048: dashboard: better ui layout for subrepo status

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5595048: code review 5595048: dashboard: better ui layout for subrepo status (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by adg

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

dashboard: better ui layout for subrepo status

Patch Set 2 : diff -r df2e1772ec73 https://go.googlecode.com/hg #

Patch Set 3 : diff -r df2e1772ec73 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 05c495f00135 https://go.googlecode.com/hg #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -77 lines)			Patch
	M	misc/dashboard/app/build/ui.go	View	1 2	4 chunks	+32 lines, -27 lines	0 comments	Download
	M	misc/dashboard/app/build/ui.html	View	1 2 3	3 chunks	+81 lines, -50 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 2 months ago (2012-01-30 05:08:54 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5595048/diff/1002/misc/dashboard/app/build/ui.html File misc/dashboard/app/build/ui.html (right): http://codereview.appspot.com/5595048/diff/1002/misc/dashboard/app/build/ui.html#newcode141 misc/dashboard/app/build/ui.html:141: <h2> A <hr /> or something above here ...

13 years, 2 months ago (2012-01-31 01:08:15 UTC) #2

adg

13 years, 2 months ago (2012-01-31 01:10:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0dbc9639d5a9 ***

dashboard: better ui layout for subrepo status

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5595048

Expand All Messages | Collapse All Messages