code review 5595044: cmd/go: add go tools to rearrangement

cmd/go: add go tools to rearrangement
fix, vet
yacc is also fixed (it was wrong before)
All that's left is the commands used during compilation
This looks like a huge CL, but it's almost all file renames.
The action is in cmd/go/pkg.go, the Makefiles, and .../doc.go.

[r, 2012-01-29 18:32:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-01-29 18:51:10]

LGTM

http://codereview.appspot.com/5595044/diff/2001/src/cmd/go/pkg.go
File src/cmd/go/pkg.go (right):

http://codereview.appspot.com/5595044/diff/2001/src/cmd/go/pkg.go#newcode271
src/cmd/go/pkg.go:271: if t.Goroot && isGoTool[elem] {
I am a little worried about people hitting this accidentally.
How about instead

if t.Goroot && isGoTool[p.ImportPath] {

and then the map above would need entries like cmd/fix cmd/vet cmd/yacc.

[r, 2012-01-29 19:07:29]

*** Submitted as 80b6f579af56 ***

cmd/go: add go tools to rearrangement
fix, vet
yacc is also fixed (it was wrong before)
All that's left is the commands used during compilation
This looks like a huge CL, but it's almost all file renames.
The action is in cmd/go/pkg.go, the Makefiles, and .../doc.go.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5595044