Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1635)

Issue 55950045: Added Juju Amulet tests for memcached charm.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by mbruzek
Modified:
5 years, 4 months ago
Reviewers:
mp+203565, Marco Ceppi
Visibility:
Public.

Description

Added Juju Amulet tests for memcached charm. Added a deploy test, testing memcached with telnet, and configuration test. https://code.launchpad.net/~mbruzek/charms/precise/memcached/trunk/+merge/203565 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added Juju Amulet tests for memcached charm. #

Total comments: 2

Patch Set 3 : Added Juju Amulet tests for memcached charm. #

Total comments: 1

Patch Set 4 : Added Juju Amulet tests for memcached charm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A tests/00_setup.sh View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tests/10_deploy_test.py View 1 2 3 1 chunk +146 lines, -0 lines 0 comments Download

Messages

Total messages: 8
mbruzek
Please take a look.
5 years, 4 months ago (2014-01-28 15:19:36 UTC) #1
lazypower
Matt, Thank you for your work on this charm test suite, it looks comprehensive enough ...
5 years, 4 months ago (2014-01-28 15:34:53 UTC) #2
mbruzek
Please take a look.
5 years, 4 months ago (2014-01-28 16:19:25 UTC) #3
mbruzek
I updated the code to respond to lazypower's code review comments.
5 years, 4 months ago (2014-01-28 16:21:14 UTC) #4
Marco Ceppi
This looks good as a test, needs some additional robustness, see inline comments https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py File ...
5 years, 4 months ago (2014-01-31 11:36:25 UTC) #5
mbruzek
Please take a look.
5 years, 4 months ago (2014-01-31 20:22:35 UTC) #6
Marco Ceppi
LGTM, with one minor fix below https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py File tests/10_deploy_test.py (right): https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py#newcode62 tests/10_deploy_test.py:62: port_string = memcached_unit.info['open-ports'][0] ...
5 years, 4 months ago (2014-02-04 18:04:30 UTC) #7
mbruzek
5 years, 4 months ago (2014-02-06 18:10:49 UTC) #8
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b