Issue 55950043: utils/ssh, provider/local: more reliable tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55950043: utils/ssh, provider/local: more reliable tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rog

Modified:
10 years, 3 months ago

Reviewers:
dimitern, mp+202802

Visibility:
Public.

Description

utils/ssh, provider/local: more reliable tests Fixes bug #1271674; papers over #1271672 The cgo-varying error message test is probably unnecessary because host lookup will probably never be invoked, but since utils/ssh tests don't pass under linux without cgo enabled, it's difficult to be sure. https://code.launchpad.net/~rogpeppe/juju-core/489-fix-trunk-tests/+merge/202802 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : utils/ssh, provider/local: more reliable tests #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/local/environprovider_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/ssh/ssh_gocrypto_test.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages