Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8122)

Issue 559450053: Issue 5733: Fix various type-conversion warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Dan Eble
Modified:
4 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5733/ 1: int->size_t in make_script_from_event () ... and similarly in Fingering_engraver::make_script (). 2: Fix scm_from_... () with wrong types 3: Fix type-conversion warning in Scale Assert that scale size is less than the max int value. 4: int->vsize in Dot_column

Patch Set 1 #

Total comments: 1

Patch Set 2 : run git-clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M lily/accidental-placement.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/dot-column.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M lily/fingering-engraver.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M lily/grob-array-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/script-interface.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/scale.cc View 3 chunks +4 lines, -1 line 0 comments Download
M lily/script-engraver.cc View 1 3 chunks +3 lines, -7 lines 0 comments Download
M lily/tab-note-heads-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
lemzwerg
LGTM https://codereview.appspot.com/559450053/diff/547570044/lily/accidental-placement.cc File lily/accidental-placement.cc (right): https://codereview.appspot.com/559450053/diff/547570044/lily/accidental-placement.cc#newcode62 lily/accidental-placement.cc:62: scm_from_long (stagger ? context_hash : 1)); Are you ...
4 years, 2 months ago (2020-02-04 10:45:58 UTC) #1
Dan Eble
On 2020/02/04 10:45:58, lemzwerg wrote: > lily/accidental-placement.cc:62: scm_from_long (stagger ? context_hash : 1)); > Are ...
4 years, 2 months ago (2020-02-04 14:37:43 UTC) #2
Dan Eble
4 years, 2 months ago (2020-02-04 19:35:08 UTC) #3
run git-clang-format
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b