code review 5593046: net: replace error variable name e, errno with err

src/pkg/net/net_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package net
 
 import (
         "flag"
         "io"
         "regexp"
@@ skipping 53 matching lines @@
 }
 
 var duplicateErrorPattern = `dial (.*) dial (.*)`
 
 func TestDialError(t *testing.T) {
         if !*runErrorTest {
                 t.Logf("test disabled; use --run_error_test to enable")
                 return
         }
         for i, tt := range dialErrorTests {
-                c, e := Dial(tt.Net, tt.Raddr)
+                c, err := Dial(tt.Net, tt.Raddr)
                 if c != nil {
                         c.Close()
                 }
-                if e == nil {
+                if err == nil {
                         t.Errorf("#%d: nil error, want match for %#q", i, tt.Pattern)
                         continue
                 }
-                s := e.Error()
+                s := err.Error()
                 match, _ := regexp.MatchString(tt.Pattern, s)
                 if !match {
                         t.Errorf("#%d: %q, want match for %#q", i, s, tt.Pattern)
                 }
                 match, _ = regexp.MatchString(duplicateErrorPattern, s)
                 if match {
                         t.Errorf("#%d: %q, duplicate error return from Dial", i, s)
                 }
         }
 }
@@ skipping 11 matching lines @@
         {"1234:567::89a:bcde", "e.d.c.b.a.9.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.7.6.5.0.4.3.2.1.ip6.arpa.", ""},
         {"1234:567:fefe:bcbc:adad:9e4a:89a:bcde", "e.d.c.b.a.9.8.0.a.4.e.9.d.a.d.a.c.b.c.b.e.f.e.f.7.6.5.0.4.3.2.1.ip6.arpa.", ""},
         {"1.2.3", "", "unrecognized address"},
         {"1.2.3.4.5", "", "unrecognized address"},
         {"1234:567:bcbca::89a:bcde", "", "unrecognized address"},
         {"1234:567::bcbc:adad::89a:bcde", "", "unrecognized address"},
 }
 
 func TestReverseAddress(t *testing.T) {
         for i, tt := range revAddrTests {
-                a, e := reverseaddr(tt.Addr)
-                if len(tt.ErrPrefix) > 0 && e == nil {
+                a, err := reverseaddr(tt.Addr)
+                if len(tt.ErrPrefix) > 0 && err == nil {
                         t.Errorf("#%d: expected %q, got <nil> (error)", i, tt.ErrPrefix)
                         continue
                 }
-                if len(tt.ErrPrefix) == 0 && e != nil {
-                        t.Errorf("#%d: expected <nil>, got %q (error)", i, e)
+                if len(tt.ErrPrefix) == 0 && err != nil {
+                        t.Errorf("#%d: expected <nil>, got %q (error)", i, err)
                 }
-                if e != nil && e.(*DNSError).Err != tt.ErrPrefix {
-                        t.Errorf("#%d: expected %q, got %q (mismatched error)", i, tt.ErrPrefix, e.(*DNSError).Err)
+                if err != nil && err.(*DNSError).Err != tt.ErrPrefix {
+                        t.Errorf("#%d: expected %q, got %q (mismatched error)", i, tt.ErrPrefix, err.(*DNSError).Err)
                 }
                 if a != tt.Reverse {
                         t.Errorf("#%d: expected %q, got %q (reverse address)", i, tt.Reverse, a)
                 }
         }
 }
 
 func TestShutdown(t *testing.T) {
         if runtime.GOOS == "plan9" {
                 return
@@ skipping 32 matching lines @@
         var buf [10]byte
         n, err := c.Read(buf[:])
         if err != nil {
                 t.Fatalf("client Read: %d, %v", n, err)
         }
         got := string(buf[:n])
         if got != "response" {
                 t.Errorf("read = %q, want \"response\"", got)
         }
 }