Refactored Juju Run

Refactored Juju Run

Proxy env vars are passed into unit context i.e. 

`[ -f "/home/ubuntu/.juju-proxy" ] && . "/home/ubuntu/.juju-proxy"`

is prepended to juju run cmd inside RunCommand.executeInUnitContext method

https://code.launchpad.net/~waigani/juju-core/refactor-juju-run/+merge/202792

(do not edit description out of merge proposal)

[waigani, 2014-01-23 06:20:01]

Please take a look.

[thumper, 2014-01-23 20:55:19]

These look good.

We were also going to check the err response from the fslock Lock method.

[waigani, 2014-01-27 09:27:38]

On 2014/01/23 20:55:19, thumper wrote:
> These look good.
> 
> We were also going to check the err response from the fslock Lock method.

In run_test.go I've written:

func (s *RunTestSuite) TestGetLock(c *gc.C) {
	_, err := getLock()
	c.Assert(err, gc.ErrorMatches, "mkdir /var/lib/juju/locks: permission denied")
}

Is this what you meant? It passes, but I don't know if  "mkdir
/var/lib/juju/locks: permission denied" is expected. I don't understand the
problem / remember why/how we were going to test the fslock?

[thumper, 2014-02-12 02:24:05]

On 2014/01/27 09:27:38, waigani wrote:
> On 2014/01/23 20:55:19, thumper wrote:
> > These look good.
> > 
> > We were also going to check the err response from the fslock Lock method.
> 
> In run_test.go I've written:
> 
> func (s *RunTestSuite) TestGetLock(c *gc.C) {
> 	_, err := getLock()
> 	c.Assert(err, gc.ErrorMatches, "mkdir /var/lib/juju/locks: permission
denied")
> }
> 
> Is this what you meant? It passes, but I don't know if  "mkdir
> /var/lib/juju/locks: permission denied" is expected. I don't understand the
> problem / remember why/how we were going to test the fslock?

Yes that is expected, and there is already another bug outstanding for that.

LGTM