Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1378)

Issue 558920043: Fix musicxml2ly.py python 2.4.5 compatibility issues

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by knupero
Modified:
7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix musicxml2ly.py python 2.4.5 compatibility issues: 1.: The encoding issues in musicxml2ly are fixed. 2.: Python 2.6 str.format() code has been replaced by code compatible to python 2.4.5. Passes complete GUB build. Results with the python 2.4.5 and 2.7 interpreters are identical for all the XMLs in the lilypond repository. The problem affected all lilypond installers since lilypond 2.19.44.

Patch Set 1 #

Patch Set 2 : Fixes chords - Do not use str.format() #

Patch Set 3 : Last part of my musicxml2ly patch. Ready for review / release. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
M python/musicexp.py View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M python/musicxml.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/musicxml2ly.py View 1 2 4 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 4
knupero
Won't be able to work on this until next week, maybe somebody has an idea ...
7 months ago (2019-07-19 06:46:53 UTC) #1
knupero
Fixes chords - Do not use str.format()
7 months ago (2019-07-20 12:54:33 UTC) #2
knupero
Last part of my musicxml2ly patch. Ready for review / release.
7 months ago (2019-07-21 17:30:43 UTC) #3
knupero
7 months ago (2019-07-21 18:23:54 UTC) #4
Ready for review now
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b