Issue 558820043: flask_tryton: Add support for 5.2 series

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 558820043: flask_tryton: Add support for 5.2 series (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by pokoli

Modified:
6 years ago

Reviewers:
resteve, ced

Visibility:
Public.

More Reviews

Patch Set 3 : Fix remarks #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	CHANGELOG	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	flask_tryton.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ced

https://codereview.appspot.com/558820043/diff/562810043/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/558820043/diff/562810043/flask_tryton.py#newcode98 flask_tryton.py:98: Cache.sync(transaction) It is not needed the Cache is sync ...

6 years, 1 month ago (2019-07-18 08:03:11 UTC) #2

ced

On 2019/07/18 09:36:26, resteve wrote: > LGTM but is missing to support py3. No it ...

6 years, 1 month ago (2019-07-18 09:52:37 UTC) #5

LGTM

Expand All Messages | Collapse All Messages