Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(494)

Issue 5587045: Expose functionality to purge the GPU texture cache while running SampleApp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by twiz
Modified:
12 years, 10 months ago
Reviewers:
bsalomon, junov1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Expose functionality to purge the GPU texture cache while running SampleApp. Press 'p' to purge the cache. A summary of the number of bytes of video memory released is output to the command prompt. Committed: https://code.google.com/p/skia/source/detail?r=3097

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M include/gpu/GrContext.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.h View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
twiz
PTAL. I believe my emacs settings remove empty lines on the end of files. Let ...
12 years, 10 months ago (2012-01-27 17:49:14 UTC) #1
bsalomon
LGTM. Just a note about how scratch textures work: When a client locks a scratch ...
12 years, 10 months ago (2012-01-27 18:02:22 UTC) #2
twiz
https://codereview.appspot.com/5587045/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.appspot.com/5587045/diff/1/include/gpu/GrContext.h#newcode81 include/gpu/GrContext.h:81: size_t getGPUTextureCacheBytes() const; On 2012/01/27 18:02:22, bsalomon wrote: > ...
12 years, 10 months ago (2012-01-27 18:58:14 UTC) #3
junov1
12 years, 10 months ago (2012-01-27 19:18:58 UTC) #4
Why not tear down the entire GrContext?  There is other state in there that
might be worth resetting on demand.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b