Issue 5581057: Minor fixes related to git.mk.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5581057: Minor fixes related to git.mk. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Daiki Ueno

Modified:
12 years, 9 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Minor fixes related to git.mk. Remove .gitignore files from the git repo, define GITIGNOREFILES in some Makefiles, and update git.mk from the Behdad upstream. BUG=none TEST=manually

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -414 lines)			Patch
D	.gitignore	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	Makefile.am	View	2 chunks	+26 lines, -0 lines	0 comments	Download
D	bus/.gitignore	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	client/x11/.gitignore	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	data/.gitignore	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	data/dconf/Makefile.am	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	debian/.gitignore	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	docs/.gitignore	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	docs/reference/ibus/.gitignore	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	gconf/.gitignore	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	git.mk	View	6 chunks	+28 lines, -9 lines	0 comments	Download
D	ibus/.gitignore	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	m4/.gitignore	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	m4/Makefile.am	View	1 chunk	+7 lines, -0 lines	0 comments	Download
D	po/.gitignore	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	setup/.gitignore	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	src/.gitignore	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	src/tests/.gitignore	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	ui/gtk/.gitignore	View	1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

Sorry if it is intentional, but I think keeping .gitignore files in git repo makes ...

12 years, 9 months ago (2012-01-31 06:58:06 UTC) #1

Peng

12 years, 9 months ago (2012-01-31 15:09:50 UTC) #2

On 2012/01/31 06:58:06, Daiki Ueno wrote:
> Sorry if it is intentional, but I think keeping .gitignore files in git repo
> makes little sense when git.mk is used.
lgtm

Expand All Messages | Collapse All Messages