Issue 5580051: code review 5580051: cmd/go: fix handling of gccgo standard library.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5580051: code review 5580051: cmd/go: fix handling of gccgo standard library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by remyoudompheng

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc, remy_archlinux.org

Visibility:
Public.

Description

cmd/go: fix handling of gccgo standard library. The previous logic was mainly non-working. It only needs to ensure that the go tool doesn't try to build the standard library with gccgo.

Patch Set 1 #

Patch Set 2 : diff -r e3cbb4364149 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e3cbb4364149 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0881a0407213 https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/cmd/go/build.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/cmd/go/pkg.go	View	1 2 3	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-01-31 07:45:39 UTC) #1

remyoudompheng

12 years, 3 months ago (2012-01-31 18:41:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4a3153e8b6bc ***

cmd/go: fix handling of gccgo standard library.

The previous logic was mainly non-working. It only needs to
ensure that the go tool doesn't try to build the standard
library with gccgo.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5580051

Expand All Messages | Collapse All Messages