Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 5577048: Fixed more warnings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by apatrick1
Modified:
12 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed more warnings. Clang warns about missing case in enum glslang_lex.cpp so I disabled that one as well. MSVC, as Chromium is built at least, warns about things in its own STL headers in SymbolTable.cpp so disabled the warning for that file. esTransform.c had a struct that the compiler could not determine was initialized so I explicitly initialized it. Committed: https://code.google.com/p/angleproject/source/detail?r=965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M samples/gles2_book/Common/esTransform.c View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/SymbolTable.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/glslang.l View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/glslang.y View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/glslang_tab.cpp View 2 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 2
apatrick1
I had some trouble rolling my recent changes into chrome. This will hopefully be the ...
12 years, 3 months ago (2012-01-25 23:09:22 UTC) #1
Zhenyao Mo
12 years, 3 months ago (2012-01-26 01:10:25 UTC) #2
On 2012/01/25 23:09:22, apatrick1 wrote:
> I had some trouble rolling my recent changes into chrome. This will hopefully
be
> the end of it!

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b