Issue 5576048: Fix the GIR annotation of ibus_bus_get_global_engine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5576048: Fix the GIR annotation of ibus_bus_get_global_engine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fujiwara

Modified:
12 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix the GIR annotation of ibus_bus_get_global_engine. BUG=none TEST=Linux_desktop

Patch Set 2 : Updated to follow message #2. #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/ibusbus.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h File src/ibusbus.h (right): https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h#newcode848 src/ibusbus.h:848: * @returns: (transfer none): The description of current global ...

12 years, 5 months ago (2012-01-26 15:55:57 UTC) #2

Peng

On 2012/01/26 15:55:57, Peng wrote: > https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h > File src/ibusbus.h (right): > > https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h#newcode848 > ...

12 years, 5 months ago (2012-01-26 16:02:40 UTC) #3

Peng

12 years, 5 months ago (2012-01-27 15:05:27 UTC) #4

Sorry. I just tried this CL. The gi parser does not recognize floating 
 keyword. Please change it back. Sorry for my previous comment.

  GICOMP IBus-1.0.gir
IBus-1.0.gir:1388:1: error: invalid value for 'transfer-ownership': floating
error parsing file IBus-1.0.gir: invalid value for 'transfer-ownership':
floating

On 2012/01/26 16:02:40, Peng wrote:
> On 2012/01/26 15:55:57, Peng wrote:
> > https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h
> > File src/ibusbus.h (right):
> > 
> > https://codereview.appspot.com/5576048/diff/1/src/ibusbus.h#newcode848
> > src/ibusbus.h:848: * @returns: (transfer none): The description of current
> > global engine,
> > Do you think use (transfer floating) is a little better for readability.
> 
> lgtm with the comment.

Expand All Messages | Collapse All Messages