Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1397)

Issue 557580043: configure.ac: Restore check for 'libguile18.h'.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by lemzwerg
Modified:
4 months ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

configure.ac: Restore check for 'libguile18.h'. This was accidentally removed in commit 670e9f7b.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment, use CPPFLAGS. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M configure.ac View 1 2 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 4
hahnjo
https://codereview.appspot.com/557580043/diff/551560043/configure.ac File configure.ac (right): https://codereview.appspot.com/557580043/diff/551560043/configure.ac#newcode198 configure.ac:198: # they rename 'libguile.h' to 'libguile18.h'. Can you be ...
4 months, 1 week ago (2020-03-06 09:05:51 UTC) #1
lemzwerg
Update comment, use CPPFLAGS.
4 months ago (2020-03-07 09:54:48 UTC) #2
hahnjo
https://codereview.appspot.com/557580043/diff/577630043/configure.ac File configure.ac (right): https://codereview.appspot.com/557580043/diff/577630043/configure.ac#newcode195 configure.ac:195: save_CPPFLAGS="$CXXFLAGS" Took me some time to find this two-character ...
4 months ago (2020-03-11 13:13:54 UTC) #3
lemzwerg
4 months ago (2020-03-11 14:02:56 UTC) #4
> configure.ac:195: save_CPPFLAGS="$CXXFLAGS"

> Took me some time to find this two-character typo :-(
> fixed in staging with commit 7fddbc0ff1

Thanks a lot!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b