Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1229)

Issue 557440043: Issue 5771: Remove unnecessary (descend-to-context ... 'Score) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by Dan Eble
Modified:
2 months, 3 weeks ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5771/ Remove an unnecessary (descend-to-context ... 'Score) ... ... from \partial: I started looking for a reason for this code, but I lost interest once I saw how old it is. input/regression/partial-polymetric.ly seems to cover the relevant case, and it still passes after removing this code. ... and from make-time-signature-set.

Patch Set 1 : rebase and add changes to make-time-signature-set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -43 lines) Patch
M ly/music-functions-init.ly View 1 chunk +4 lines, -9 lines 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +27 lines, -29 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Dan Eble
https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly#newcode1319 ly/music-functions-init.ly:1319: 'origin (*location*) I'm curious about when it is important ...
4 months, 3 weeks ago (2020-02-17 16:59:54 UTC) #1
dak
https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly#newcode1319 ly/music-functions-init.ly:1319: 'origin (*location*) On 2020/02/17 16:59:54, Dan Eble wrote: > ...
4 months, 3 weeks ago (2020-02-17 18:41:58 UTC) #2
Dan Eble
On 2020/02/17 18:41:58, dak wrote: > Are you sure this is actually a working idea? ...
4 months, 3 weeks ago (2020-02-17 19:17:04 UTC) #3
dak
On 2020/02/17 19:17:04, Dan Eble wrote: > On 2020/02/17 18:41:58, dak wrote: > > Are ...
4 months, 3 weeks ago (2020-02-17 19:33:24 UTC) #4
Dan Eble
3 months ago (2020-04-10 18:51:13 UTC) #5
make-time-signature-set
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b