Issue 5572055: Enable warnings as errors.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5572055: Enable warnings as errors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by apatrick1

Modified:
14 years, 2 months ago

Reviewers:
Zhenyao Mo, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Enable warnings as errors. I didn't do it for translator_common though because it contains automatically generated code. This is improve the signal to noise ratio in the chromium build logs. Committed: https://code.google.com/p/angleproject/source/detail?r=960

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -0 lines)			Patch
M	build/common.gypi	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/build_angle.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/translator_hlsl.vcproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	src/libEGL/libEGL.vcproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.vcproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

apatrick1

Any objections to this Daniel? zmo: can you look at the gyp files? Thanks, Al

14 years, 2 months ago (2012-01-24 19:52:16 UTC) #1

Zhenyao Mo

On 2012/01/24 19:52:16, apatrick1 wrote: > Any objections to this Daniel? > > zmo: can ...

14 years, 2 months ago (2012-01-24 20:58:38 UTC) #2

dgkoch

14 years, 2 months ago (2012-01-24 21:04:08 UTC) #3

LGTM - feel free to fix the one in translator_common as well :-)

Expand All Messages | Collapse All Messages