Issue 5572046: Rename ibus_engine_new_type with ibus_engine_new_with_type.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5572046: Rename ibus_engine_new_type with ibus_engine_new_with_type. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fujiwara

Modified:
12 years, 5 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Rename ibus_engine_new_type with ibus_engine_new_with_type. seed assigns GType in IBus.Engine.type and also assignes "*_new_foo" method in IBus.Engine.foo so renamed the function. BUG=http://code.google.com/p/ibus/issues/detail?id=1397 TEST=Linux_desktop with seed and gjs

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to follow message #2 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	src/ibusengine.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ibusengine.c	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/ibusfactory.c	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

12 years, 5 months ago (2012-01-23 15:28:46 UTC) #2

LGTM with a comment

http://codereview.appspot.com/5572046/diff/1/src/ibusengine.h
File src/ibusengine.h (right):

http://codereview.appspot.com/5572046/diff/1/src/ibusengine.h#newcode173
src/ibusengine.h:173: * @engine_type: GType of subclass of IBUS_TYPE_ENGINE
GType of #IBusEngine or subclass of #IBusEngine.

Expand All Messages | Collapse All Messages