Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1522)

Issue 557080043: Issue 5568: make build output terse by default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by Dan Eble
Modified:
5 months, 2 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5568/ The goal is to show progress without burying warnings and errors in the noise of long commands. Options VERBOSE=1 and SILENT=1 make the output more like the usual "make" and "make -s" (respectively). The verbosity level affects the options that are passed to some commands, but there is room for improvement in this area.

Patch Set 1 #

Patch Set 2 : add ly_progress to centralize formatting #

Patch Set 3 : s&r ly_info -> ly_progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -8 lines) Patch
M Documentation/GNUmakefile View 1 2 9 chunks +16 lines, -0 lines 0 comments Download
M Documentation/css/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/logo/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/ly-examples/GNUmakefile View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Documentation/misc/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/pictures/GNUmakefile View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Documentation/po/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/topdocs/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M GNUmakefile.in View 1 2 6 chunks +11 lines, -0 lines 0 comments Download
M elisp/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/lilypond-book/GNUmakefile View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M input/regression/musicxml/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M lily/GNUmakefile View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M make/abc-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M make/doc-i18n-root-rules.make View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M make/generic-rules.make View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M make/lilypond-book-rules.make View 1 2 4 chunks +15 lines, -0 lines 0 comments Download
M make/lilypond-book-vars.make View 1 chunk +4 lines, -0 lines 0 comments Download
M make/lilypond-vars.make View 1 chunk +3 lines, -3 lines 0 comments Download
M make/ly-rules.make View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M make/lysdoc-rules.make View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M make/midi-rules.make View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M make/musicxml-rules.make View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M make/mutopia-rules.make View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M make/stepmake.make View 1 1 chunk +55 lines, -0 lines 0 comments Download
M mf/GNUmakefile View 1 2 7 chunks +11 lines, -0 lines 0 comments Download
M stepmake/stepmake/c++-rules.make View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M stepmake/stepmake/c-rules.make View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M stepmake/stepmake/documentation-rules.make View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M stepmake/stepmake/executable-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/generic-rules.make View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M stepmake/stepmake/help2man-rules.make View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M stepmake/stepmake/library-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/metafont-rules.make View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M stepmake/stepmake/metafont-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/python-module-rules.make View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M stepmake/stepmake/script-rules.make View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M stepmake/stepmake/shared-library-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/substitute-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/test-rules.make View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/tex-rules.make View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 2 8 chunks +15 lines, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-vars.make View 1 chunk +5 lines, -0 lines 0 comments Download
M vim/GNUmakefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10
Dan Eble
6 months ago (2019-10-04 22:00:40 UTC) #1
lemzwerg
Thanks for your efforts. Some comments. * What about using the automake format, for example ...
6 months ago (2019-10-04 23:23:19 UTC) #2
Dan Eble
On 2019/10/04 23:23:19, lemzwerg wrote: > * I can imagine that it makes more sense ...
6 months ago (2019-10-05 02:05:49 UTC) #3
lemzwerg
> It should be the build directory. If you know how to achieve it > ...
6 months ago (2019-10-05 10:57:56 UTC) #4
Dan Eble
add ly_progress to centralize formatting
6 months ago (2019-10-05 12:56:02 UTC) #5
Dan Eble
s&r ly_info -> ly_progress
6 months ago (2019-10-05 12:59:57 UTC) #6
Dan Eble
On 2019/10/04 23:23:19, lemzwerg wrote: > * The idea of showing the type of input ...
6 months ago (2019-10-05 13:26:24 UTC) #7
lemzwerg
We are getting nearer, thanks :-) The next thing I notice is that `ly_progress` is ...
6 months ago (2019-10-05 13:44:54 UTC) #8
Dan Eble
On 2019/10/05 13:44:54, lemzwerg wrote: > We are getting nearer, thanks :-) > > What ...
6 months ago (2019-10-05 14:19:29 UTC) #9
lemzwerg
6 months ago (2019-10-05 14:39:35 UTC) #10
> > What about using `$$@` (or something like that to delay expansion) in
> > the definition of `ly_progress` and omitting `Making` as an argument,
> > too?  This would give
> >
> >   $(call ly_progress,<comment>)
> 
> Too rigid.  [...]

Ok.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b