Issue 5570066: Increase MSVC warning level to 4.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5570066: Increase MSVC warning level to 4. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by apatrick1

Modified:
12 years, 10 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Increase MSVC warning level to 4. There are some exceptions, a subset of the exceptions used by Chromium. They didn't seem to be useful warnings. In code which we don't change much, like the preprocessor, I just suppressed the warnings in the specific files rather than changing the code. There should be no functional changes in this patch. Committed: https://code.google.com/p/angleproject/source/detail?r=964

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -136 lines)			Patch
M	build/common.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/gles2_book/Common/esUtil.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	samples/gles2_book/MipMap2D/MipMap2D.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/translator/translator.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ConstantUnion.h	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/compiler/Intermediate.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	src/compiler/glslang.l	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/glslang.y	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	2 chunks	+24 lines, -20 lines	0 comments	Download
M	src/compiler/preprocessor/cpp.c	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/memory.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/scanner.c	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/preprocessor/symbols.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/tokens.c	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/translator_common.vcproj	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/compiler/translator_hlsl.vcproj	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/libEGL/libEGL.cpp	View	35 chunks	+1 line, -70 lines	0 comments	Download
M	src/libEGL/libEGL.vcproj	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/libGLESv2/Buffer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Context.cpp	View	5 chunks	+4 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Program.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Texture.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.cpp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.vcproj	View	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Zhenyao Mo

12 years, 10 months ago (2012-01-25 21:48:17 UTC) #2

On 2012/01/25 20:41:04, apatrick1 wrote:
> Not as bad as it looks.

LGTM.  Thanks for cleaning all the mess up.

Expand All Messages | Collapse All Messages