Issue 5570061: Fix remaining compiler warnings in translator_common.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5570061: Fix remaining compiler warnings in translator_common. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by apatrick1

Modified:
14 years, 2 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix remaining compiler warnings in translator_common. One MSVC warning and one GCC warning. I also added a variable to build_angle.gyp that will enforce various rules not normally applied to third party software when built as part of chromium. Committed: https://code.google.com/p/angleproject/source/detail?r=962

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	src/build_angle.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/glslang.l	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/compiler/translator_common.vcproj	View		4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Zhenyao Mo

https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp File src/compiler/glslang_tab.cpp (left): https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp#oldcode1734 src/compiler/glslang_tab.cpp:1734: } This will not work. This code is generated, ...

14 years, 2 months ago (2012-01-25 00:35:20 UTC) #2

apatrick1

14 years, 2 months ago (2012-01-25 00:38:18 UTC) #3

Zhenyao Mo

14 years, 2 months ago (2012-01-25 00:43:55 UTC) #4

On 2012/01/25 00:38:18, apatrick1 wrote:
> https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp
> File src/compiler/glslang_tab.cpp (left):
> 
>
https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp#ol...
> src/compiler/glslang_tab.cpp:1734: }
> On 2012/01/25 00:35:20, Zhenyao Mo wrote:
> > This will not work.  This code is generated, so next time you regenerate,
this
> > will be added back.
> 
> It doesn't get regenerated as part of the build though so you can delete this
> block of code. Easier than patching bison :)

LGTM then, but could you add a comment in place of the removed block so the next
guy modifying the compiler will know to delete it again.

Expand All Messages | Collapse All Messages