Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 5570061: Fix remaining compiler warnings in translator_common. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by apatrick1
Modified:
14 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix remaining compiler warnings in translator_common. One MSVC warning and one GCC warning. I also added a variable to build_angle.gyp that will enforce various rules not normally applied to third party software when built as part of chromium. Committed: https://code.google.com/p/angleproject/source/detail?r=962

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/build_angle.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/glslang.l View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 1 1 chunk +2 lines, -6 lines 0 comments Download
M src/compiler/translator_common.vcproj View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
apatrick1
PTAL. Thanks.
14 years, 2 months ago (2012-01-25 00:29:27 UTC) #1
Zhenyao Mo
https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp File src/compiler/glslang_tab.cpp (left): https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp#oldcode1734 src/compiler/glslang_tab.cpp:1734: } This will not work. This code is generated, ...
14 years, 2 months ago (2012-01-25 00:35:20 UTC) #2
apatrick1
https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp File src/compiler/glslang_tab.cpp (left): https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp#oldcode1734 src/compiler/glslang_tab.cpp:1734: } On 2012/01/25 00:35:20, Zhenyao Mo wrote: > This ...
14 years, 2 months ago (2012-01-25 00:38:18 UTC) #3
Zhenyao Mo
14 years, 2 months ago (2012-01-25 00:43:55 UTC) #4
On 2012/01/25 00:38:18, apatrick1 wrote:
> https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp
> File src/compiler/glslang_tab.cpp (left):
> 
>
https://codereview.appspot.com/5570061/diff/1/src/compiler/glslang_tab.cpp#ol...
> src/compiler/glslang_tab.cpp:1734: }
> On 2012/01/25 00:35:20, Zhenyao Mo wrote:
> > This will not work.  This code is generated, so next time you regenerate,
this
> > will be added back.
> 
> It doesn't get regenerated as part of the build though so you can delete this
> block of code. Easier than patching bison :)

LGTM then, but could you add a comment in place of the removed block so the next
guy modifying the compiler will know to delete it again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b