Issue 5569058: Explicitly disable warnings for auto-generated files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5569058: Explicitly disable warnings for auto-generated files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by apatrick1

Modified:
14 years, 2 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Explicitly disable warnings for auto-generated files. I think this is better than modifying the auto-generated files. Committed: https://code.google.com/p/angleproject/source/detail?r=963

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+616 lines, -406 lines)			Patch
M	src/compiler/glslang.l	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/glslang.y	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	9 chunks	+14 lines, -21 lines	0 comments	Download
M	src/compiler/glslang_tab.h	View	4 chunks	+113 lines, -20 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	153 chunks	+475 lines, -365 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

I realized I can avoid modifying the auto-generated code like this.

14 years, 2 months ago (2012-01-25 01:55:37 UTC) #1

Zhenyao Mo

14 years, 2 months ago (2012-01-25 02:07:23 UTC) #2

On 2012/01/25 01:55:37, apatrick1 wrote:
> I realized I can avoid modifying the auto-generated code like this.

LGTM

Expand All Messages | Collapse All Messages