Issue 55680043: worker: Firewaller using the API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55680043: worker: Firewaller using the API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by dimitern

Modified:
10 years, 3 months ago

Reviewers:
mp+202695, natefinch, rog

Visibility:
Public.

Description

worker: Firewaller using the API Final step of the firewaller API chain: the firewaller worker is changed to use only the API and have no state connection. https://code.launchpad.net/~dimitern/juju-core/251-worker-firewaller-api/+merge/202695 Requires: https://code.launchpad.net/~dimitern/juju-core/250-api-firewaller/+merge/202693 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+221 lines, -134 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	27 chunks	+118 lines, -77 lines	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	29 chunks	+95 lines, -50 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

10 years, 3 months ago (2014-01-22 22:23:21 UTC) #4

On 2014/01/22 19:16:17, rog wrote:
> LGTM, assuming you've verified that it works live.

Yes, I checked on EC2 and it seems the firewaller works just as well with the
API.

Expand All Messages | Collapse All Messages