Issue 55670043: state/api: Firewaller client-side API facade

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55670043: state/api: Firewaller client-side API facade (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dimitern

Modified:
11 years, 3 months ago

Reviewers:
mp+202693, rog

Visibility:
Public.

Description

state/api: Firewaller client-side API facade With this, the firewaller API implementation is complete, and in a follow-up the actual worker will be changed to use it. https://code.launchpad.net/~dimitern/juju-core/250-api-firewaller/+merge/202693 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state/api: Firewaller client-side API facade #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+921 lines, -64 lines)			Patch
[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
state/api/common/life.go	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
state/api/deployer/deployer.go	View	1	2 chunks	+1 line, -17 lines	0 comments	Download
state/api/firewaller/firewaller.go	View	1	1 chunk	+101 lines, -0 lines	0 comments	Download
state/api/firewaller/firewaller_test.go	View		1 chunk	+80 lines, -0 lines	0 comments	Download
state/api/firewaller/machine.go	View		1 chunk	+66 lines, -0 lines	0 comments	Download
state/api/firewaller/machine_test.go	View		1 chunk	+92 lines, -0 lines	0 comments	Download
state/api/firewaller/service.go	View		1 chunk	+90 lines, -0 lines	0 comments	Download
state/api/firewaller/service_test.go	View		1 chunk	+91 lines, -0 lines	0 comments	Download
state/api/firewaller/state_test.go	View		1 chunk	+99 lines, -0 lines	0 comments	Download
state/api/firewaller/unit.go	View		1 chunk	+125 lines, -0 lines	0 comments	Download
state/api/firewaller/unit_test.go	View		1 chunk	+122 lines, -0 lines	0 comments	Download
state/api/machiner/machiner.go	View	1	2 chunks	+1 line, -17 lines	0 comments	Download
state/api/provisioner/provisioner.go	View	1	1 chunk	+1 line, -15 lines	0 comments	Download
state/api/state.go	View		2 chunks	+7 lines, -0 lines	0 comments	Download
state/api/uniter/uniter.go	View	1	1 chunk	+1 line, -15 lines	0 comments	Download
state/apiserver/root.go	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM with one suggestion below. https://codereview.appspot.com/55670043/diff/1/state/api/firewaller/firewaller.go File state/api/firewaller/firewaller.go (right): https://codereview.appspot.com/55670043/diff/1/state/api/firewaller/firewaller.go#newcode26 state/api/firewaller/firewaller.go:26: func (st *State) life(tag ...

11 years, 3 months ago (2014-01-22 19:12:14 UTC) #2

dimitern

11 years, 3 months ago (2014-01-22 22:38:07 UTC) #3

Please take a look.

https://codereview.appspot.com/55670043/diff/1/state/api/firewaller/firewalle...
File state/api/firewaller/firewaller.go (right):

https://codereview.appspot.com/55670043/diff/1/state/api/firewaller/firewalle...
state/api/firewaller/firewaller.go:26: func (st *State) life(tag string)
(params.Life, error) {
On 2014/01/22 19:12:15, rog wrote:
> This is the fifth almost-identical implementation of this function. Seems like
> it might be a good candidate for putting in common.

Done.

Expand All Messages | Collapse All Messages