Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(301)

Issue 5562048: code review 5562048: net: ListenMulticastUDP to listen concurrently across m... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mikio
Modified:
9 years, 6 months ago
Reviewers:
CC:
rsc, paul.a.lalonde_gmail.com, albert.strasheim, dho, golang-dev
Visibility:
Public.

Description

net: ListenMulticastUDP to listen concurrently across multiple listeners This CL introduces new function ListenMulticastUDP to fix multicast UDP listening across multiple listeners issue, to replace old multicast methods JoinGroup and LeaveGroup on UDPConn. This CL also enables multicast testing by default. Fixes issue 2730.

Patch Set 1 : diff -r 49bf7083ea05 https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 2 : diff -r 23995c78329e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f36b37b08176 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 2426e2c1018e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 48a0594d7375 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -119 lines) Patch
doc/go1.html View 1 2 3 4 1 chunk +7 lines, -2 lines 0 comments Download
doc/go1.tmpl View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
src/pkg/net/multicast_test.go View 1 2 3 6 chunks +27 lines, -49 lines 0 comments Download
src/pkg/net/sock.go View 1 1 chunk +10 lines, -1 line 0 comments Download
src/pkg/net/sock_bsd.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
src/pkg/net/sock_linux.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
src/pkg/net/sock_windows.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
src/pkg/net/sockopt_bsd.go View 1 2 1 chunk +27 lines, -9 lines 0 comments Download
src/pkg/net/sockopt_linux.go View 1 2 1 chunk +19 lines, -7 lines 0 comments Download
src/pkg/net/sockopt_windows.go View 1 2 2 chunks +14 lines, -6 lines 0 comments Download
src/pkg/net/udpsock_plan9.go View 1 2 1 chunk +6 lines, -16 lines 0 comments Download
src/pkg/net/udpsock_posix.go View 1 2 3 5 chunks +71 lines, -27 lines 0 comments Download

Messages

Total messages: 13
mikio
Hello rsc@golang.org, paul.a.lalonde@gmail.com, fullung@gmail.com, devon.odell@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
9 years, 6 months ago (2012-01-25 13:39:20 UTC) #1
rsc
based on our earlier email discussion, i believe that this will be the end of ...
9 years, 6 months ago (2012-01-25 22:45:26 UTC) #2
albert.strasheim
LGTM. I'll try to get it tested in our multicast app today. Re: Russ's question. ...
9 years, 6 months ago (2012-01-26 04:20:00 UTC) #3
mikio
On Thu, Jan 26, 2012 at 7:45 AM, Russ Cox <rsc@golang.org> wrote: > based on ...
9 years, 6 months ago (2012-01-26 13:19:37 UTC) #4
dho
2012/1/25 <fullung@gmail.com>: > LGTM. I'll try to get it tested in our multicast app today. ...
9 years, 6 months ago (2012-01-26 15:09:09 UTC) #5
rsc
Great. Can you please remove the Group methods in this CL?
9 years, 6 months ago (2012-01-26 15:11:48 UTC) #6
mikio
Will do -- Mikio On Jan 27, 2012, at 12:11 AM, Russ Cox <rsc@golang.org> wrote: ...
9 years, 6 months ago (2012-01-26 16:24:47 UTC) #7
mikio
I think all comments are addressed. - add ListenMulticastUDP - remove both JoinGroup, LeaveGroup - ...
9 years, 6 months ago (2012-01-28 14:28:40 UTC) #8
mikio
Hello rsc@golang.org, paul.a.lalonde@gmail.com, fullung@gmail.com, devon.odell@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-01-28 14:29:37 UTC) #9
mikio
Hello rsc@golang.org, paul.a.lalonde@gmail.com, fullung@gmail.com, devon.odell@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-01-28 18:57:44 UTC) #10
dho
Lgtm On Jan 28, 2012 1:57 PM, <mikioh.mikioh@gmail.com> wrote: > Hello rsc@golang.org, paul.a.lalonde@gmail.com, fullung@gmail.com, > ...
9 years, 6 months ago (2012-01-28 20:22:03 UTC) #11
rsc
LGTM http://codereview.appspot.com/5562048/diff/15054/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5562048/diff/15054/doc/go1.tmpl#newcode1116 doc/go1.tmpl:1116: There are also new methods s/methods/functions/ http://codereview.appspot.com/5562048/diff/15054/doc/go1.tmpl#newcode1121 doc/go1.tmpl:1121: ...
9 years, 6 months ago (2012-01-29 17:48:28 UTC) #12
mikio
9 years, 6 months ago (2012-01-31 16:53:32 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=e92908c9c87d ***

net: ListenMulticastUDP to listen concurrently across multiple listeners

This CL introduces new function ListenMulticastUDP to fix
multicast UDP listening across multiple listeners issue,
to replace old multicast methods JoinGroup and LeaveGroup
on UDPConn.

This CL also enables multicast testing by default.

Fixes issue 2730.

R=rsc, paul.a.lalonde, fullung, devon.odell
CC=golang-dev
http://codereview.appspot.com/5562048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b