Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1030)

Issue 556041: code review 556041: install.html: elaborate on shell profile instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by adg
Modified:
11 years, 8 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

install.html: elaborate on shell profile instructions

Patch Set 1 #

Patch Set 2 : code review 556041: install.html: suggest .profile instead of .bashrc #

Patch Set 3 : code review 556041: install.html: elaborate on shell profile instructions #

Total comments: 1

Patch Set 4 : code review 556041: install.html: elaborate on shell profile instructions #

Patch Set 5 : code review 556041: install.html: elaborate on shell profile instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M doc/install.html View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 8 months ago (2010-03-14 23:16:58 UTC) #1
james toy
Hi, FWIW I have been using this all along on all of the supported platforms ...
11 years, 8 months ago (2010-03-15 11:17:38 UTC) #2
r2
I thought bash used .bash_profile. There's probably some nuance but you can avoid by saying ...
11 years, 8 months ago (2010-03-15 14:59:32 UTC) #3
rsc
.bashrc and .profile are not the same thing. .bashrc runs on every bash shell. .profile ...
11 years, 8 months ago (2010-03-15 17:10:32 UTC) #4
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 8 months ago (2010-03-15 22:24:35 UTC) #5
rsc
LGTM (but wait for r)
11 years, 8 months ago (2010-03-15 22:26:47 UTC) #6
adg
I removed the first reference to .bashrc as it seemed redundant, and elaborated in the ...
11 years, 8 months ago (2010-03-15 22:27:01 UTC) #7
r
LGTM http://codereview.appspot.com/556041/diff/9001/10001 File doc/install.html (right): http://codereview.appspot.com/556041/diff/9001/10001#newcode110 doc/install.html:110: <code>$HOME/.profile</code>, or equivalent). For example: this isn't really ...
11 years, 8 months ago (2010-03-15 22:36:03 UTC) #8
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=607029c0c3b4 *** install.html: elaborate on shell profile instructions R=r, rsc CC=golang-dev http://codereview.appspot.com/556041
11 years, 8 months ago (2010-03-15 22:42:38 UTC) #9
james toy
11 years, 8 months ago (2010-03-16 12:37:07 UTC) #10
On Mon, Mar 15, 2010 at 13:10, Russ Cox <rsc@golang.org> wrote:

> .bashrc and .profile are not the same thing.
> .bashrc runs on every bash shell.
> .profile runs only on login (and if using bash, only if .bash_profile
> does not exist).
> In windowed environments it's often quite hard to get
> a .profile or .bash_profile to rerun (you have to log in again)
> but easy to get .bashrc rerun (you open a new window).
>

agreed; however, standard mac os x terminal.app does not exhibit this
behavior (though i bet the xterm in the X11 implementation does).  if you
open a new tab / window / terminal -- it always rereads the .profile (i
think it runs them as login shells).


>
> I agree with Rob that you can finesse the issue by saying
> "in your shell profile," but we should keep the reference
> to .bashrc, because it *is* working for so many people.
> Many people who try to install Go don't know what
> a shell profile is, and some don't know about environment
> variables.  I don't want to remove detail here.
> How about something like:
>
> ... in your shell profile ($HOME/.bashrc or $HOME/.profile or equivalent).


i think profile is a more elegant solution -- but for the "just works"
factor the .bashrc is certainly doing the trick.  i do think anymore
documentation on this is off-topic so i think your solution is good.

LGTM

james toy


>
>
> On Sun, Mar 14, 2010 at 15:16,  <adg@golang.org> wrote:
> > Reviewers: r, rsc,
> >
> > Message:
> > Hello r, rsc (cc: golang-dev@googlegroups.com),
> >
> > I'd like you to review this change.
> >
> >
> > Description:
> > install.html: suggest .profile instead of .bashrc
> >
> > This works more universally, and thus should reduce the
> > installation issues experienced by some.
> >
> > Please review this at http://codereview.appspot.com/556041/show
> >
> > Affected files:
> >  M doc/install.html
> >
> >
> > Index: doc/install.html
> > ===================================================================
> > --- a/doc/install.html
> > +++ b/doc/install.html
> > @@ -20,7 +20,7 @@
> >  <h2>Environment variables</h2>
> >
> >  <p>The Go compilation environment depends on three environment
> > -variables that you should set in your <code>.bashrc</code> or
> equivalent,
> > +variables that you should set in your <code>.profile</code> or
> equivalent,
> >  plus one optional variable:</p>
> >
> >  <dl>
> > @@ -106,7 +106,8 @@
> >  </p>
> >
> >  <p>
> > -Set these variables in your <code>.bashrc</code>.  For example:
> > +Set these variables in <code>$HOME/.profile</code> or equivalent.
> > +For example:
> >  </p>
> >
> >  <pre>
> >
> >
> >
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b