Issue 5557064: Moved RefCountObject to common so it can be used by libEGL.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5557064: Moved RefCountObject to common so it can be used by libEGL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by apatrick1

Modified:
12 years, 3 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Moved RefCountObject to common so it can be used by libEGL. Committed: https://code.google.com/p/angleproject/source/detail?r=956

Patch Set 1 #

Patch Set 2 : Updated path to RefCountObject in Query #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -147 lines)			Patch
M	src/build_angle.gyp	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
A +	src/common/RefCountObject.h	View		3 chunks	+3 lines, -8 lines	0 comments	Download
A +	src/common/RefCountObject.cpp	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/common/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Buffer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Context.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Framebuffer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Query.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	src/libGLESv2/RefCountObject.h	View	1	1 chunk	+0 lines, -70 lines	0 comments	Download
D	src/libGLESv2/RefCountObject.cpp	View	1	1 chunk	+0 lines, -52 lines	0 comments	Download
M	src/libGLESv2/Renderbuffer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Texture.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.vcproj	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

apatrick1

This is so EGLImage can use it. I checked that both the gyp and sln ...

12 years, 3 months ago (2012-01-20 00:34:30 UTC) #1

dgkoch

LGTM provided there were no functional changes to the Refcount class when it moved..

12 years, 3 months ago (2012-01-20 18:30:31 UTC) #2

apatrick1

12 years, 3 months ago (2012-01-20 19:01:52 UTC) #3

On 2012/01/20 18:30:31, dgkoch wrote:
> LGTM provided there were no functional changes to the Refcount class when it
> moved..

No it was a straight refactor. The only thing I considered doing (but didn't)
was somehow factoring out the integer ID for objects that don't need one.

Expand All Messages | Collapse All Messages