Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2128)

Issue 5557049: Remove apparent SkIntToScalar(SkScalar) call in SkScalerContext_FreeType (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by epoger
Modified:
12 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove apparent SkIntToScalar(SkScalar) call in SkScalerContext_FreeType This change seems to fix the following assertion failure we have been seeing in the Skia_Linux_Fixed_Debug build since http://code.google.com/p/skia/source/detail?r=3059 : drawing... bitmapfilters [540 330] ../include/core/SkFixed.h:67: failed assertion "n >= -32768 && n <= 32767" Committed: https://code.google.com/p/skia/source/detail?r=3066

Patch Set 1 #

Total comments: 1

Patch Set 2 : properly convert biased integer to SkScalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
epoger
This change seems to alleviate the problem, but I'm not certain if we expect the ...
12 years, 9 months ago (2012-01-18 18:39:34 UTC) #1
Steve VanDeBogart
https://codereview.appspot.com/5557049/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.appspot.com/5557049/diff/1/src/ports/SkFontHost_FreeType.cpp#newcode1425 src/ports/SkFontHost_FreeType.cpp:1425: x_height = bbox.yMax / 64; I'd guess that the ...
12 years, 9 months ago (2012-01-18 18:45:43 UTC) #2
epoger
changed to use SkFDot6ToFixed() at Mike's suggestion
12 years, 9 months ago (2012-01-18 18:53:56 UTC) #3
reed1
lgtm
12 years, 9 months ago (2012-01-18 19:14:57 UTC) #4
junov1
12 years, 9 months ago (2012-01-18 19:31:42 UTC) #5
Is it normal for the bbox to have such large values?  I think the failure we are
seeing here is a symptom of a deeper problem, which I will continue to
investigate. The canvas's transform matrix seems to be out of whack, and I think
something I put in SkDeferredCanvas might not be SkFixed friendly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b