Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1560)

Issue 5554052: Stop writing out XPS baselines until we resolve skia issue 455 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by epoger
Modified:
12 years, 7 months ago
Reviewers:
bungeman
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Stop writing out XPS baselines until we resolve skia issue 455 BUG=455 TBR=bungeman Committed: https://code.google.com/p/skia/source/detail?r=3068

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gm/gmmain.cpp View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3
epoger
12 years, 7 months ago (2012-01-18 20:10:52 UTC) #1
bungeman
Don't really have a problem with it, but here is a suggested other way to ...
12 years, 7 months ago (2012-01-18 20:29:46 UTC) #2
epoger
12 years, 7 months ago (2012-01-18 20:31:17 UTC) #3
On 2012/01/18 20:29:46, bungeman wrote:
> Don't really have a problem with it, but here is a suggested other way to go
> about doing things.
> 
> http://codereview.appspot.com/5554052/diff/1/gm/gmmain.cpp
> File gm/gmmain.cpp (right):
> 
> http://codereview.appspot.com/5554052/diff/1/gm/gmmain.cpp#newcode525
> gm/gmmain.cpp:525: generate_xps(gm, document);
> followed by
> 
> // Until we resolve http://code.google.com/p/skia/issues/detail?id=455 ,
> // stop writing out XPS-format image baselines in gm.
> return ERROR_NONE;
> 
> This would mean xps would still be run for gm, and so any problems we
currently
> detect will still be detected.

Oh, that's a good point.  Unfortunately I already committed the change. :-(

Do you want me to make a new change like you describe here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b