Issue 555230043: Remove check for rational bugfix.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 555230043: Remove check for rational bugfix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by hanwenn

Modified:
5 years, 12 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove check for rational bugfix. The bugfix is included with GUILE 1.8.2

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	configure.ac	View		1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dak

6 years ago (2020-02-02 13:36:09 UTC) #1

LGTM

We probably have quite a number of those leftovers that are completely
irrelevant by now.  I almost lean towards stipulating that any code for
pre-Guile-1.8.8 can be removed directly without review, but then if something
does go wrong by accident, we at least have a bit of a trace to see what went
wrong.

Expand All Messages | Collapse All Messages