Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(584)

Issue 5552056: code review 5552056: build: add include files for Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by ality
Modified:
13 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

build: add include files for Plan 9 Previously, I had made available a tarball of the modified system headers that were necessary to build on Plan 9 but that was only a stopgap. I think this method is much better since no files outside of $GOROOT will have to be added or modified during the build process. Also, this is just the first step. I'll change the build to reference these files in another CL (that also contains a few more Makefile changes).

Patch Set 1 #

Patch Set 2 : diff -r e3cbb4364149 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e3cbb4364149 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 82ecd6cd5141 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A include/plan9/386/u.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
A include/plan9/libc.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A include/plan9/mach.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A include/plan9/ureg_amd64.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
A include/plan9/ureg_arm.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
A include/plan9/ureg_x86.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
ality
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-01-31 11:40:26 UTC) #1
rsc
LGTM
13 years, 2 months ago (2012-01-31 15:50:13 UTC) #2
ality
13 years, 2 months ago (2012-02-01 02:14:51 UTC) #3
*** Submitted as 89d981d7aa78 ***

build: add include files for Plan 9

Previously, I had made available a tarball of
the modified system headers that were necessary
to build on Plan 9 but that was only a stopgap.
I think this method is much better since no
files outside of $GOROOT will have to be added
or modified during the build process.

Also, this is just the first step. I'll change
the build to reference these files in another CL
(that also contains a few more Makefile changes).

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5552056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b