Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 5544045: code review 5544045: json: better error messages when the ,string option is ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by bradfitz
Modified:
14 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

json: better error messages when the ,string option is misused Fixes issue 2331

Patch Set 1 #

Patch Set 2 : diff -r 0057bb55bbfd https://go.googlecode.com/hg #

Patch Set 3 : diff -r 0057bb55bbfd https://go.googlecode.com/hg #

Patch Set 4 : diff -r 0057bb55bbfd https://go.googlecode.com/hg #

Patch Set 5 : diff -r d33a0a5fcdc0 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -413 lines) Patch
M src/buildscript_darwin_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_darwin_amd64.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_freebsd_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_freebsd_amd64.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_linux_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_linux_amd64.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_linux_arm.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_netbsd_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_netbsd_amd64.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_openbsd_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_openbsd_amd64.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_plan9_386.sh View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M src/buildscript_windows_386.sh View 1 2 3 4 chunks +20 lines, -20 lines 0 comments Download
M src/buildscript_windows_amd64.sh View 1 2 3 4 chunks +20 lines, -20 lines 0 comments Download
M src/pkg/encoding/json/decode.go View 1 6 chunks +28 lines, -7 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
14 years, 9 months ago (2012-01-12 22:11:24 UTC) #1
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 9 months ago (2012-01-12 22:33:19 UTC) #2
bradfitz
(now with updated buildscripts) On Thu, Jan 12, 2012 at 2:33 PM, <bradfitz@golang.org> wrote: > ...
14 years, 9 months ago (2012-01-12 22:34:33 UTC) #3
rsc
LGTM
14 years, 9 months ago (2012-01-12 22:37:39 UTC) #4
bradfitz
14 years, 9 months ago (2012-01-12 22:40:33 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=53aa2f7bd4f5 ***

json: better error messages when the ,string option is misused

Fixes issue 2331

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5544045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b